cancel the network stream if AsyncStream is cancelled, #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for approach and feedback. UPD: We added your solution to 1.4.0 version. Thank you for contributing and help us and our library being better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love that your package supports stopping streams. That seems to be a major gap in other packages. Thank you.
I'm using the AsyncThrowing stream in a Task, and noticed that if I cancel the Task, then the cancellation automatically propagates to the stream.
This was actually a problem as it meant I didn't get a chance to check for Task.isCancelled - and stop the networkStream manually.
Then I realised that this can be done automatically using onTermination of the continuation.
Thoughts?